LogoLogo
  • OFN Testing Documentation
  • Feature Testing Handbook
    • 1. Background
    • 2. Testing
    • 3. Reporting Feedback
    • 4. Launching the next action
  • Manual Testing Handbook
    • 1. Getting started
    • 2. How to do a sanity check (release testing)?
    • 3. How to do a sanity check in production (after a release)?
    • 4. Test cases
    • 5. Work in Progress
  • Automated Testing Handbook
    • System Specs
    • Automate release testing
    • Some more background
    • (R)Spec Conventions
  • Testers Toolkit
    • Multi-Account Containers
    • Flaky specs
    • Re-running Migrations
    • Enabling Open Street Maps
    • Performance testing with Postman
    • Reverting Database Changes
Powered by GitBook
On this page

Was this helpful?

  1. Automated Testing Handbook

(R)Spec Conventions

Some spec conventions on OFN, mostly outputs from code review

  • around, before and after blocks go before the it block. These belong together and makes it easier to understand in which conditions the examples are ran.

For reference see this review.

  • We should not use I18n.t("key") on specs but rather use the string it refers to on specs, instead.

For reference see this discussion and related issues:

https://github.com/openfoodfoundation/openfoodnetwork/issues/9499

https://github.com/openfoodfoundation/openfoodnetwork/issues/9500

  • Global methods are usually not a good idea: one should include private / def blocks within the respective describe / context blocks.

For reference, see this commit.

PreviousSome more backgroundNextTesters Toolkit

Last updated 2 years ago

Was this helpful?