(R)Spec Conventions

Some spec conventions on OFN, mostly outputs from code review

  • around, before and after blocks go before the it block. These belong together and makes it easier to understand in which conditions the examples are ran.

For reference see this review.

  • We should not use I18n.t("key") on specs but rather use the string it refers to on specs, instead.

For reference see this discussion and related issues:

https://github.com/openfoodfoundation/openfoodnetwork/issues/9499

https://github.com/openfoodfoundation/openfoodnetwork/issues/9500

  • Global methods are usually not a good idea: one should include private / def blocks within the respective describe / context blocks.

For reference, see this commit.

Last updated